Skip to content

fix(compose): Fix and modernise compose.yml #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2022
Merged

fix(compose): Fix and modernise compose.yml #345

merged 1 commit into from
Feb 14, 2022

Conversation

@Ferenc-
Copy link
Member

@Ferenc- Ferenc- commented Feb 6, 2022

  • Adds a few needed environment variables
  • Bumps the versions of redis and mongo to the same levels used by circleci
  • Enables starting the stack with podman (Without using DNS in Container Networks)
  • Minimizes the scope of shared volumes to the absolutely needed config files
  • Uses the :Z to have the runtime label the content with a private unshared label.
  • Removes unused services
  • Removes outdated comments

andriikushch
andriikushch approved these changes Feb 9, 2022
View reviewed changes
Copy link

@andriikushch andriikushch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Ferenc- Ferenc- merged commit 5a822b6 into master Feb 14, 2022
@Ferenc- Ferenc- deleted the fix/docker-compose branch February 14, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@cedricziel cedricziel cedricziel approved these changes

@andriikushch andriikushch andriikushch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Ferenc- @cedricziel @andriikushch